Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1592

Fix buck plugin finder root

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/kageiit/fix_plugin_finder into master Oct 18, 2017
  • Overview 12
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: kageiit

https://github.com/decebals/pf4j/blob/1822cdede37ba649033021583ab29ee662835071/pf4j/src/main/java/org/pf4j/PropertiesPluginDescriptorFinder.java#L39

Without this fix, the following warnings are thrown when buck starts up on the main console

[2017-10-18 16:33:58.844][error][command:null][tid:15][org.pf4j.CompoundPluginDescriptorFinder] Cannot find 'plugins/analytics-plugin/plugin.properties' path
[2017-10-18 16:33:58.847][error][command:null][tid:15][org.pf4j.CompoundPluginDescriptorFinder] Cannot find the manifest path
[2017-10-18 16:33:58.848][error][command:null][tid:15][org.pf4j.AbstractPluginManager] No PluginDescriptorFinder for plugin 'plugins/analytics-plugin'
org.pf4j.PluginException: No PluginDescriptorFinder for plugin 'plugins/analytics-plugin'
    at org.pf4j.CompoundPluginDescriptorFinder.find(CompoundPluginDescriptorFinder.java:78)
    at org.pf4j.AbstractPluginManager.loadPluginFromPath(AbstractPluginManager.java:786)
    at org.pf4j.DefaultPluginManager.loadPluginFromPath(DefaultPluginManager.java:137)
    at org.pf4j.AbstractPluginManager.loadPlugins(AbstractPluginManager.java:230)
    at com.facebook.buck.plugin.BuckPluginManagerFactory.createPluginManager(BuckPluginManagerFactory.java:39)
    at com.facebook.buck.cli.Main.runMainWithExitCode(Main.java:569)
    at com.facebook.buck.cli.Main.runMainThenExit(Main.java:389)
    at com.facebook.buck.cli.Main.nailMain(Main.java:1840)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.martiansoftware.nailgun.NGSession.run(NGSession.java:329)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kageiit/fix_plugin_finder