Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1615

Fix building of apple_test with is_ui_test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/robbertvanginkel/xcuitest_deps into master Nov 10, 2017
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 11

Created by: robbertvanginkel

apple_test targets have a test_host if the tests test an application, used to set the -bundle_loader argument during linking to provide the test bundle with the symbols that would be available when the test bundle gets injected into the app.

With #1505, I introduced a change that when a test target is marked as is_ui_test, it would not set this bundle loader flag. This is because XCUITests don't run injected into the app, but in a separate process. The implementation in that PR made sure the test_host_app wouldn't be passed when creating a test target, having the unintended side effect of removing the runtime dependency of test host app. This resulted in the test host app not being build when doing buck build //test:target.

This PR changes it so that the TestHostInfo can be created and passes the test_host_app. This way the runtime dependency stays in place while the host app is not used as bundle_loader.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/robbertvanginkel/xcuitest_deps