Created by: jiangty-addepar
(This PR is on top of https://github.com/facebook/buck/pull/1653, so ignore the first commit for now.)
This is a collection of TestNG test improvements from our fork of Buck. Changes include:
-
Minor fixes to testng runner.- Mark skipped tests as failed
- No hard time limit per test suite
-
Respect ClassName and MethodName filters in TestNG runner.- Make ClassName / MethodName filters work with TestNG runner
- Remove TestNGWrapper
- Remove "TmpSuite" xml suite
-
TestNG results now show method parameters.- Show method parameters in TestNG test results (for example, for tests that use DataProviders)
-
Support Stdout and Exception Details when Test Setup Fails- Fail test and print exceptions/stdout when test setup fails
- Record all test failures in JUnit test report, including those from test setup
The remaining changes are to tests. I did some refactoring to use the buck cell (reducing jar duplication) for an existing test as well.
Test plan: buck test; added a number of integration tests.