Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1787

Fixing Machos file scrubbers to correctly handle cgo binaries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/monty-uber/fix-scrubber-step into master Mar 01, 2018
  • Overview 24
  • Commits 6
  • Pipelines 0
  • Changes 2

Created by: monty-uber

This addresses the bug logged in https://github.com/facebook/buck/issues/1717.

When a FileScrubberStep fails, it currently causes the entire build to fail. This shouldn't be critical behavior as the scrubber merely increases the effectiveness of the cache between builds.

This is a problem because the scrubbing methods used in com.facebook.buck.cxx.toolchain.objectfile.Machos currently do not work on Mach-O object files created from cgo files. You can see the behavior by running the test binaryWithCgo in com.facebook.buck.go.GoBinaryIntegrationTest on Mac.

I'll create another issue about the scrubbers not handling cgo object files.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/monty-uber/fix-scrubber-step