Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1788

Add FrameworkPaths from dependencies to SwiftCompile

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/robbertvanginkel/prebuilt_framework_swift into master Mar 01, 2018
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 8

Created by: robbertvanginkel

The dependency flags passed to SwiftCompile by the AppleLibraryDescriptionSwiftEnhancer currently only include "include" flags. This is not sufficient as some rules export frameworks as part of the rule, and the framework search paths for those need to be visible to use the framework.

This change adds the FrameworkPaths to the PreprocessorFlags that are passed when creating the swiftcompile rule. Those are included in the compile command in getSwiftIncludeArgs, but unfortunately this prefixes them with -Xcc to only make them visible to the clang importer. The frameworks search paths need to be seen visible to both the clang and swift compiler, which is why the paths are also added without -Xcc. This duplication is unfortunate but does not cause problems.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/robbertvanginkel/prebuilt_framework_swift