Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1789

Fixed #1714 and #1791

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/linzhp/cgo-deps into master Mar 02, 2018
  • Overview 18
  • Commits 2
  • Pipelines 0
  • Changes 8

Created by: linzhp

Issues and solutions:

#1714 (closed): the cgo_deps parameter of a go_library rule was not copied to the go_test rules targeting at the go_library rule. So when the go_test rules were built, the cgo_library rules needed by the go_library were not built.

Solution: Copy cgo_deps from go_library to go_test

#1791 (closed): When Buck was calling cgo to generate the import file, it sets the package name to be the full package name with paths. As a result, the package statement in the resulting Go file has the full package name with / and . in it, causing syntax error when the Go file is compiled.

Solution: Only use the last part of the package name in the cgo-generated go source

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/linzhp/cgo-deps