Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1826

[WorkerProcessPool] Replace busy wait w/ `Thread#join()`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/davidaurelio/worker-pool-test into master Mar 30, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: davidaurelio

These tests were using a busy wait approach in order to avoid timeouts on CI systems like Travis.

Test threads get into different states across different test runs and systems.

Here, we replace all busy waits for thread states with Thread#join(500).

Given the small workloads of the test threads, this should be enough even for Travis CI.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davidaurelio/worker-pool-test