Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1835

Prevent frameworks being copied to appex targets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/KieranLafferty/fix_swift_appex_framework_copy into master Apr 06, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: KieranLafferty

Using @zayhero's fix to prevent the swift std lib files from being copied over when the target is an extension.

Extensions can not contain a Frameworks folder in them and must instead rely on their parent app's frameworks.

Using the following build settings, Xcode was able to build without the inclusion of MyExtension.appex/Framewworks, however when built with buck the MyExtension.appex/Framewworks existed with the copied swift libs.

MyExtension.appex build settings

  'ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES': 'NO',
    'EMBEDDED_CONTENT_CONTAINS_SWIFT': 'NO',
    'RUNPATH_SEARCH_PATHS': '@executable_path/../../Frameworks'

If a Frameworks folder is found in an .appex the itunes connect validation will give the following error:

ERROR ITMS-90206: "Invalid Bundle. The bundle at 'Yarn.app/PlugIns/Notification.appex' contains disallowed file 'Frameworks'."

This PR resolves the above issue by skipping the copy step if the target is an APPEX extension

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/KieranLafferty/fix_swift_appex_framework_copy