Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1894

Drop `arm` as a default CPU ABI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/LegNeato/remove_arm_default into master May 23, 2018
  • Overview 17
  • Commits 1
  • Pipelines 0
  • Changes 15

Created by: LegNeato

With the latest version of the NDK, arm is not supported.

Fixes https://github.com/facebook/buck/issues/1890.

This could possibly be a breaking change for people who have not set CPU ABI and are not using the latest NDK---before their builds would have arm, after updating Buck they will no longer and might wonder what happened. Open to strategies to dealing with that, though they can always just add arm to cpu_abis in their config to fix any bustage. While buck could detect this case, it seems like a bit too much magic to be worth it.

Note that this is somewhat related to https://github.com/facebook/buck/pull/1889 but not exactly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/LegNeato/remove_arm_default