Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1975

Ignore buck-out

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/linzhp/ignore-buck-out into master Jul 24, 2018
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: linzhp

According to the doc, buck-out should be automatically ignored. This PR implements that, to avoid crashes when running buck build //...

java.lang.IllegalStateException: Target '//buck-out/gen/protobuf/google/google:google' refers to file 'buck-out/gen/protobuf/google/google', which doesn't belong to any package
	at com.facebook.buck.parser.ThrowingPackageBoundaryChecker.enforceBuckPackageBoundaries(ThrowingPackageBoundaryChecker.java:60)
	at com.facebook.buck.parser.DefaultParserTargetNodeFactory.createTargetNodeFromObject(DefaultParserTargetNodeFactory.java:210)
	at com.facebook.buck.parser.DefaultParserTargetNodeFactory.createTargetNode(DefaultParserTargetNodeFactory.java:166)
	at com.facebook.buck.parser.DefaultParserTargetNodeFactory.createTargetNode(DefaultParserTargetNodeFactory.java:1)
	at com.facebook.buck.parser.TargetNodeParsePipeline.computeNodeInScope(TargetNodeParsePipeline.java:106)
	at com.facebook.buck.parser.TargetNodeParsePipeline.computeNodeInScope(TargetNodeParsePipeline.java:1)
	at com.facebook.buck.parser.ConvertingPipelineWithPerfEventScope.computeNode(ConvertingPipelineWithPerfEventScope.java:68)
	at com.facebook.buck.parser.ConvertingPipeline.dispatchComputeNode(ConvertingPipeline.java:143)
	at com.facebook.buck.parser.ConvertingPipeline.lambda$1(ConvertingPipeline.java:81)
	at com.facebook.buck.parser.PipelineNodeCache.getJobWithCacheLookup(PipelineNodeCache.java:73)
	at com.facebook.buck.parser.ConvertingPipeline.lambda$0(ConvertingPipeline.java:74)
	at com.google.common.util.concurrent.AbstractTransformFuture$AsyncTransformFuture.doTransform(AbstractTransformFuture.java:206)
	at com.google.common.util.concurrent.AbstractTransformFuture$AsyncTransformFuture.doTransform(AbstractTransformFuture.java:195)
	at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:115)
	at com.google.common.util.concurrent.MoreExecutors$5$1.run(MoreExecutors.java:999)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@ttsugriy @mkaczanowski Please take a look. Thanks!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/linzhp/ignore-buck-out