Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2028

Add CFBundleIdentifier key when looking for toolchains.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/vkalintiris/vkal/check-bundle-id into master Sep 18, 2018
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: vkalintiris

This will allow us to look for both "Identifier" and "CFBundleIdentifier" in the toolchains plist file. This is needed because the official Xcode toolchain uses the "Identifier" key but the open-source Swift toolchains only set the "CFBundleIdentifier" key.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/vkalintiris/vkal/check-bundle-id