Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2054

Allow for thread_core_ratio of above 1.0 if reserved_core isn't set

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/keithprestonsc/threadRatio into master Oct 10, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: keithprestonsc

This changes the logic to make thread_core above 1 work

Previously we unconditionally ran: if (scaledValue > threadLimit) { scaledValue = threadLimit; }

Which eliminated values over 1.0.

Now we only run it if reserved_core is set

Also with the new logic "thread_core_ratio_max_cores is larger than thread_core_ratio_reserved_cores allows"); is not necessary.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/keithprestonsc/threadRatio