Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2086

Don't run resource union in MiniAapt

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/raviagarwal7/ravi/resource-union-fix into master Nov 02, 2018
  • Overview 13
  • Commits 2
  • Pipelines 0
  • Changes 5

Created by: raviagarwal7

  • Resource union is already handled by MergeAndroidResourcesStep.java, which also has information about the entires parents.
  • In MiniAapt resource union would load each resource file individually, merge them and put them in R.txt using natural ordering. This breaks styleable generation.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/raviagarwal7/ravi/resource-union-fix