Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2101

Apple project generator respects default cxx platform

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ghvg1313/apple-platform-project-gen into master Nov 20, 2018
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 10

Created by: ghvg1313

Resolves https://github.com/facebook/buck/issues/2032 using a different approach.

This PR essentially solve two issues:

  1. supported_platforms_regex now won't be included in the undesired platform, originally this could create an empty project target or unsupported source/header being included.
  2. Header collision by glob usage in exported_platform_headers, this is covered in detail in https://github.com/facebook/buck/issues/2032

@williamtwilson While i don't think this is a very elegant solution it does the job. Since this reverted couple of commits (bd07dcd6, 4ab71d6a and abb6939c) and uses a different approach than excluding headers based on platform, I'm up for discussion

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ghvg1313/apple-platform-project-gen