Created by: thalescm
This project shows that the current buck implementation of android app bundles is buggy, and the presented PR fixes it while adding more security and scalability to the feature, as it removes a lot of logic from buck that is already maintained by google (bundletool).
- Added bundletool to the project, bundle tool is now used to create the final bundle.
- Bundletool correctly generates android app bundle configuration files (current impl don't)
- Bundletool correctly adds bundletool version used (on BundleConfig.pb) so playstore knows which one to use when creating apks
- Bundletool will validate the modules before building the final bundle (this dosn't exist on current implementation, so on success build of
android_bundlerule can be a false positive)
- Moving module files to the right places; as documentation explains: https://developer.android.com/guide/app-bundle/
- Removed Assets,Native and BundleConfig generation steps, as this is now covered by bundletool itself.