Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2168

Remove spurious format arg

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rneatherway/extra-format-arg into master Jan 16, 2019
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: rneatherway

Hi, I've been looking at using Buck, and so I thought I'd browse the analysis results on LGTM.com, since I'm one of the developers!

I've fixed a couple of fairly clear issues here, although they weren't currently active bugs. Let me know if it's easier if I split it into two PRs. For reference the links are:

  • https://lgtm.com/projects/g/facebook/buck/rev/5e81dc96ae29630a160f0e61e691cfbd6a8fed0b. For this one we have analysed back to the introduction point so you can see the commit that introduced it and it could have showed up on the PR.
  • https://lgtm.com/projects/g/facebook/buck/snapshot/9c567e107fc4bab664a019d73d94d91742733cb9/files/src/com/facebook/buck/features/haskell/HaskellLibraryDescription.java#xa4d4c55938f68330:1
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rneatherway/extra-format-arg