Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2227

Include Prebuilt jar's transitiveClasspath when building the javaplugin properties

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/raviagarwal7/ravi/fix-transitives into master Apr 02, 2019
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: raviagarwal7

PrebuiltJar has deps which is exported by default. Include it’s transitiveClasspath when building the javaplugin properties (https://github.com/facebook/buck/blob/master/src/com/facebook/buck/jvm/java/AbstractJavacPluginProperties.java#L97).

Previously: With rules defined below dagger processor will only have javaDep and firstLevelPrebuilt in its classpath.

After: With rules defined below dagger processor will only have javaDep, firstLevelPrebuilt and transitivePrebuilt as well. Same is the behaviour if the prebuilt is added as a dependency to a java library since deps of prebuilt are exported by default.

java_annotation_processor(
    name = 'dagger',
    deps = [
         '//:javaDep',
         '//lib/firstLevelPrebuilt'
     ]
)

prebuilt_jar(
    name = 'firstLevelPrebuilt'
    deps = [
        '//lib:transitivePrebuilt'
    ]
)

prebuilt_jar(
    name = 'transitivePrebuilt'
)

Added Tests.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/raviagarwal7/ravi/fix-transitives