Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !224

Improve the messages printed when buck self-updates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dpursehouse/improve-messages-when-buck-updates into master Dec 16, 2014
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: dpursehouse

Summary:

(1.) When the .buckversion file specifies a revision that is not present in the current repository, print a message stating that Buck is fetching updates.

(2.) When the git fetch fails, only display a "failed" message. Move the bit about how the user can disable the update into the informational message that was already displayed as described in (1.).

(3.) If the revision specified in .buckversion does not exist on the remote, either because it's plain wrong or because the revision is on a remote that is not configured in the local repository, the git checkout fails. Catch the exception and display a message rather than a Python Traceback.

Test Plan:

Set .buckversion to a revision that does not exist. Run buck clean and observe that it prints the message in (1.), then runs git fetch, and then fails to check out the revision and fails with an error message.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dpursehouse/improve-messages-when-buck-updates