Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2257

Replace "incorrect" types to make project generation work with xcodeproj

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/fdiaz/fix-types-projectgen into master May 10, 2019
  • Overview 13
  • Commits 2
  • Pipelines 0
  • Changes 4

Created by: fdiaz

Buck currently outputs an XML for project.pbxproj where runOnlyForDeploymentPostprocessing and dstSubfolderSpec are treated as integer.

			<key>runOnlyForDeploymentPostprocessing</key>
			<integer>1</integer>
			<key>dstSubfolderSpec</key>
			<integer>16</integer>

When trying to open the .xcodeproj file with xcodeproj we're getting:

[Xcodeproj] Type checking error: got Fixnum for attribute: Attribute dstSubfolderSpec (type: simple, classes: [String], owner class: PBXCopyFilesBuildPhase)

This seems to be a bug in xcodeproj itself.

To work around this, I'm forcing these 2 keys to have Strings as values instead of Int. After doing this, xcodeproj can succesfully open our project.

This was all already done in our fork of buck here


I'm also including here @donholly commit in their fork that adds the same workaround for the same issue in PBXContainerItemProxy https://github.com/Clubroom/buck/commit/8fa5ae58c5df0e991d2f2e80830a73206c384bf3

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/fdiaz/fix-types-projectgen