Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2267

Fix secondary Xcode schemes ignoring action_config_names settings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rockbruno/master into master May 24, 2019
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: rockbruno

Fixes https://github.com/facebook/buck/issues/2265

We use the following setup to create a secondary scheme that sends Enterprise builds:

xcode_workspace_config(
    name = "workspace",
    workspace_name = "MyApp",
    src_target = ":MyApp",
    environment_variables = ENV_VAR,
    extra_schemes = {
      'MyApp-Enterprise': ':myapp_enterprise_workspace',
    }
)

xcode_workspace_config(
    name = "myapp_enterprise_workspace",
    workspace_name = "MyApp-Enterprise",
    src_target = ":MyApp",
    environment_variables = ENV_VAR,
    action_config_names = {"archive": "Release-Enterprise"},
)

However, setting action_config_names on the secondary scheme currently has no effect because the schemes were always pointing to the main scheme's configs.

This PR fixes this to make secondary schemes pull their configs from their own definition.

Note that this will affect projects that were relying on this to have all schemes having the same configs and has the side effect that project scheme's actions won't be equal to workspaceArguments anymore - should we keep the old interaction if custom configs weren't provided?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rockbruno/master