Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2270

Fix error message when Android build-tools directory is empty

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/makovkastar/empty-android-build-tools-error-message into master May 26, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: makovkastar

Before this fix, when a user didn't have any Android build tools installed and tried to build an Android Buck project, he would have got the following error message: null was empty, but should have contained a subdirectory with build tools. Install them using the Android SDK Manager (/Users/username/Library/Android/sdk/tools/android). This PR provides the absolute path to the 'build-tools' directory instead of 'null': /Users/username/Library/Android/sdk/build-tools was empty, but should have contained a subdirectory with build tools. Install them using the Android SDK Manager (/Users/username/Library/Android/sdk/tools/android). It also fixes the corresponding unit test, which had the error message hardcoded.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/makovkastar/empty-android-build-tools-error-message