Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2306

Bump Kotlin to 1.3.50 and Move KAPT to 1 pass

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tyvsmith/ts/kotlin-1.3.50-and-kapt-1-pass into master Aug 28, 2019
  • Overview 16
  • Commits 5
  • Pipelines 0
  • Changes 19

Created by: tyvsmith

  • Bumped Kotlin version to 1.3.50 jars in thirdparty and in test data dir.
  • Applied @thalescm diff to move Kapt to 1 pass. (Taking over https://github.com/facebook/buck/pull/2250)

Some advantages of this flow:

  • This is more optimised then calling kotlinc 3 times
  • We stop depending on kotlin-compiler-embeddable libs and kotlin-annotation-processing-gradle for the expected ones (kotlin-compiler and kotlin-annotation-processing)
  • Code is now simpler with one call to kotlinc only

Caveats: Kotlin versions prior to 1.3.50 won't be supported since they don't support this Kapt configuration.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tyvsmith/ts/kotlin-1.3.50-and-kapt-1-pass