Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2348

Create schemes for APP_EXTENSION subtypes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dropbox/more-extensions into master Nov 18, 2019
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: bogo

Buck will not auto-create schemes for app extensions that are subtypes of the APP_EXTENSION (com.apple.product-type.app-extension ) type. Those are, among others, the iMessage apps. (com.apple.product-type.app-extension.messages)

To avoid adding all possible extension types to the ProductTypes, this PR modifies scheme creation to check if the product type BEGINS with the parent extension type. Open to other suggestions on how to fix this if this is deemed too hacky!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dropbox/more-extensions