Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2402

[apple_asset_catalog] Fix Messages Extension App Icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/davidxiasc/dxia/actool-product-type into master Feb 24, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 7

Created by: davidxiasc

Addresses https://github.com/facebook/buck/issues/2400

Currently, building Messages extensions with buck will not generate the Messages app icon correctly. This is because in order to do so, actool needs to know what product type it is creating an asset catalog + app icon for.

This change funnels the product type from apple_bundle into AppleAssetCatalog and AcToolStep so that actool is called with --product-type <product type> (needs to be com.apple.product-type.app-extension.messages for Messages extensions).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davidxiasc/dxia/actool-product-type