Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2409

Hg test fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/v-jizhang/hg_test_fix into master Mar 06, 2020
  • Overview 0
  • Commits 17
  • Pipelines 0
  • Changes 1

Created by: v-jizhang

There is a test passes internally but fails in CircleCI

Failed target: //test/com/facebook/buck/util/versioncontrol:versioncontrol
FAIL com.facebook.buck.util.versioncontrol.HgCmdLineInterfaceIntegrationTest

That is caused by the differences between FB hg and open source hg. In this particular case, FB hg output message is longer than that of open source hg. The fix is to assert the expected message contains the actual result, that should . be true both for FB hg and open source hg.

The following test should pass: buck test //test/com/facebook/buck/util/versioncontrol:versioncontrol

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/v-jizhang/hg_test_fix