Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2429

make buck Python3 compatible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/v-jizhang/cherry_pick_py3 into master Mar 24, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: v-jizhang

Summary: The function attributes named func_X have been renamed to use the X form in Python3, https://docs.python.org/3/whatsnew/3.0.html#operators-and-special-methods and also built-in changes https://wiki.python.org/moin/Python3.0#Built-In_Changes. The old names can't be used in Python3. This PR changes the old names to new names to make buck Python3 compatible. Python2 was EOL on 1/1/2020, https://github.com/Homebrew/homebrew-core/issues/49796. Pull Request resolved: https://github.com/facebook/buck/pull/2391

Reviewed By: philipjameson, v-jizhang

Pulled By: v-jizhang

shipit-source-id: c00dae81ea0e0356ebacb2429ddee26bb8fe9362

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/v-jizhang/cherry_pick_py3