Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2590

[1/n Dynamic Feature Support] Create Android Optimiser layer and segregate responsibility of AndroidBinaryBuildable and AndroidBinaryOptimizer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/uKetki/refactor_optimizer into master Feb 22, 2021
  • Overview 3
  • Commits 6
  • Pipelines 0
  • Changes 25

Created by: uKetki

The commit addresses the below changes:

  • Creating a light AndroidBinaryBuildable by extracting optimizer flow from buildable
  • Refactored Android Buildable layer and segregated responsibility of AndroidBinaryBuildable
  • Defining AndroidBinaryPathUtility class with all possible paths for aab and apk
  • Adding BinaryType enum to segregate apk and aab flow

Looking at the buck code for generating apk and aab, it is evident that AndroidBinaryBuildable is bloated with a lot of responsibilities ranging from apk/aab generation, signing to optimization.

The overview of current buck architecture: Existing Binary generation logic

The suggestion is to refactor existing code and create two separate layers: Optimizers and Buildable which can re-use the common logic for binary generation and offload the specific implementation to the respective layers: Buildable Optimizer


This approach will later help to add changes needed to support dynamic feature delivery.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/uKetki/refactor_optimizer