Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2596

Fixing Kotlin ABI issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tyvsmith/fix-kotlin-abi-usage into master Mar 09, 2021
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 6

Created by: tyvsmith

This addresses two bugs when dealing with ABI classes for Kotlin.

  1. If you're using a mixed source set or a kt target without any kt files, the folder isn't generated to hold the abi class files. When an upstream target tries to consume this target, it fails because of a missing folder. This creates the temp folder if it's supporting source abi generation.

  2. For Class ABIs, methods with synthetic parameters were stripped. The means that overrides become problematic across targets. This preserves more signatures in the case of Kotlin by keeping synthetic methods for Kotlin.

This has been tested and deployed on the internal Uber Buck fork.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tyvsmith/fix-kotlin-abi-usage