Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2625

Use original JUnit test class name instead of suite class in test XML report

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Warren requested to merge github/fork/swarren12/bugfix/junit-test-suite-fix-master into master May 19, 2021
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 6

As discussed in #2623, this change will use the original test class name instead of the test suite name when generating the test output XML when run against a JUnit suite.

I've tried to keep the change as small as possible by overloading the TestCaseSummary constructor to default the new testSuite parameter to false, so that all the other usages of this aren't affected, but if it's better to push this default up to the places where this class is instantiated then I can do that instead!

One thing that CI pointed out to me was that changing the shape of TestCaseSummary caused a unit test to fail because there are checks on how this object serialises. I've updated that test, but I'm not familiar with what the actual implications of changing this are and whether that suggests that maybe I should be achieving this result in a different way.

Also, one CI job is failing but I don't believe that's related to my change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/swarren12/bugfix/junit-test-suite-fix-master