Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !2697

Get Buck working for 3.10 (backport to main)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge python3.10-on-main into main May 04, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 11

Created by: bigfootjon

Cherry-picked from https://github.com/facebook/buck/commit/1ae1e6c078255529930a31e49f55e5bfff7b9d3f (#2696)

Fixes: https://github.com/facebook/buck/issues/2678

Test plan:

I ran buck for a personal project that uses py3.10 syntax (Foo | None) and it was able to build and run correctly

Original commit message:

On 3.10 some collections classes have been moved to collections.abc and it causes Buck 1 to crash. This diff fixes those instances.

Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex.

Reviewed By: bigfootjon

fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: python3.10-on-main