Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !278

Add zip_safe flag to all python targets & set it to False on cxx_python_extension

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mike Kaplinskiy requested to merge github/fork/mikekap/zip_safe into master Mar 31, 2015
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 25

Native libraries are not zipsafe (see https://docs.python.org/2/library/zipimport.html "only files .py and .py[co] are available for import. ZIP import of dynamic modules (.pyd, .so) is disallowed"). This change introduces the zip_safe flag on all python targets that can potentially be not-zip-safe, and marks cxx_python_extension as definitely-not zip safe.

I made it a tristate in PythonPackageComponents mostly to keep the default from being hardcoded in every python rule.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mikekap/zip_safe