Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !317

Fix buck build on Java 8

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/davido/patch-2 into master May 26, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: davido

Buck, by default, builds java_library targets with first order deps only, so that transitive dependencies don't considered.

So the target '//src/com/facebook/buck/rules:types' is using SmartDexingStep class that implements Step class. Step class is not used directly by this target and Java 7 compiler is happy about it. However Java8 compiler needs to touch Step class because of default methods and cannot reach it, even though it's contained in the transitive dependency chain:

rules:types => rules:build_rule => step:step

To verify this, the following command can be used

$ buck build --build-dependencies=TRANSITIVE
//src/com/facebook/buck/rules:types

To fix the problem for both compilers, add step:step as direct dependency to the rules:types target.

TEST PLAN:

$ buck build //src/com/facebook/buck/rules:types

on both Java 7 and java 8 should succeed.

This addresses an issue raised in #312 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davido/patch-2