Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !379

AdbHelper: only restart adb when no device is attached

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tgummerer/restart-multi into master Jul 14, 2015
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: tgummerer

Summary: Currently the adb server is restarted both when there is no device attached, or when there is more than one device attached, but the user hasn't enabled multi install mode. Restarting the adb server helps when adb is flaky and shows devices as offline or not attached, but it doesn't help when there are too many devices are attached and the user forgets to enable multi install mode. This is usually a user error.

Disable the server restart and save a little time for the user.

Test plan: Test buck install with different device configurations and show it does the right thing about restarting the adb server.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tgummerer/restart-multi