Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !497

Fix bug in build-with-buck with library targets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/adamhowardprice/adamprice/build-with-buck-apple-lib into master Nov 06, 2015
  • Overview 14
  • Commits 2
  • Pipelines 0
  • Changes 5

Created by: adamhowardprice

Summary: Running buck project //src:foo --build-with-buck creates a project that cannot be built in Xcode if //src:foo is a library target. Previously we used one shell script that 1) built the project with Buck and 2) fixed UUIDs in the binary. Now we add the shell script to build in all cases, but only add the fix_uuid script if it is an apple_bundle.

Test plan: Unit tests updated. ant java-test -Dtest.class=ProjectGeneratorTest. Also, build an apple_bundle, apple_binary and apple_library, with buck project <target> --build-with-buck --combined-project and make sure all generated Xcode projects build correctly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/adamhowardprice/adamprice/build-with-buck-apple-lib