Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !498

Stop skipping tests in ProjectGeneratorTest, fix one test that would have failed if it wasn't being skipped.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/adamhowardprice/adamprice/fix-project-generator-tests into master Nov 08, 2015
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: adamhowardprice

Summary: Had been skipping 3 tests because of unsatisfied assumptions that didn't affect the test. Removed assumptions and fixed some mistakes in the testAggregateTargetForBundleForBuildWithBuck test. These mistakes were previously committed and passed CI because of the unnecessary assumptions.

Test Plan: ant java-test -Dtest.class=ProjectGeneratorTest

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/adamhowardprice/adamprice/fix-project-generator-tests