Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !499

Add getEnvironment to Tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mike Kaplinskiy requested to merge github/fork/mikekap/tool_env into master Nov 09, 2015
  • Overview 7
  • Commits 12
  • Pipelines 0
  • Changes 81

This is quite incomplete - I wanted to get first impressions on the approach. It's basically adding an ImmutableMap<String, String> environment to all the steps that use getCommandPrefix. To some extent I wonder if passing Tool to the steps instead would be better - although I suppose that's a bit harder to test with.

Separately, if you could, let me know whether you prefer a commit per directory or one giant squash. I'm hoping one-per-directory makes it easier to review, but it's definitely a PITA to bisect.

Either way - let me know if this looks good. I'll finish the other ~70 uses once I get the ok :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mikekap/tool_env