Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !508

Decouple JavaLibrary from AnnotationProcessingParams

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/grumpyjames/feature/jvmlang-agnostic-2 into master Nov 13, 2015
  • Overview 5
  • Commits 3
  • Pipelines 0
  • Changes 7

Created by: grumpyjames

Summary: We only need to expose the generated source directory (which may not exist). As AnnotationProcessingParams is java specific (rather than jvmlang agnostic) we'd prefer JavaLibrary (soon to become JvmLibrary) to not know about it.

Context: I'm another LMAX person. We really want to make some progress towards the work described in https://github.com/facebook/buck/pull/439

Tested with ant && ./bin/buck test (advice on whether this is enough gratefully received!)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/grumpyjames/feature/jvmlang-agnostic-2