Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !524

Fix iteration order of structure dicts within diff_rulekeys.py

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/grumpyjames/misc/python-compatibility-1 into master Nov 19, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: grumpyjames

Summary: Different Python versions have differently-deterministic iteration order for defaultdicts. We change to using an OrderedDict to avoid ambiguity. We discovered this tracking down tests that failed in travis and not locally (travis is on 2.7.3, we are on 2.7.5)

Test Plan: CI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/grumpyjames/misc/python-compatibility-1