Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !530

Untracked files now affect get_dirty_buck_version

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rhencke/dirtier into master Nov 26, 2015
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: rhencke

Before, the presence of untracked files caused Buck to return a dirty version, but those untracked files were not used in calculating the dirty version. This meant that creating the first untracked file caused the buck daemon to restart, but any subsequent modifications to any untracked files did not. Now, any change to files tracked or untracked (but not ignored) will affect the dirty version.

Quick way to see the behavior before and after:

git clean -fd # remove any untracked changes
./bin/buck # daemon starts/restarts
touch a
./bin/buck # daemon restarts
touch b
./bin/buck # previously, daemon does not restart.  now, daemon restarts.

(Sadly, a little slower, but overall still much faster than before combined with the previous change to re-use index.)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rhencke/dirtier