Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !541

Break out DefaultSuggestBuildRules from DefaultJavaLibrary

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/grumpyjames/feature/jvmlang-agnostic-9 into master Dec 02, 2015
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 6

Created by: grumpyjames

Summary:

It feels like it would be nice to test it without having to rely on DefaultJavaLibrary, so we extract out the previously anonymous SuggestBuildRules implementation, rework its inputs to make it look a little more like a pure function. We also split the existing test into two cases and substantially rework the tests to make adding further cases a little simpler.

Test-plan: CI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/grumpyjames/feature/jvmlang-agnostic-9