Created by: davido
Rule can be provided from different cell and thus output file name must be relocated according to cell root. Change all the methods on JavaLibraryClasspathProvider that take Optional outputJar to take Optional outputJar instead.
SourcePaths are much safer because they encapsulate the project filesystem. That way we know they can always be resolved correctly.
Closes #545 (closed)
TEST PLAN:
Clone JGit with this patch: [1]. Clone Gerrit Code Review with this patch: [2]. Replace JGit cell during Gerrit build, with:
$ buck build --config repositories.jgit=../jgit gerrit
Observe, that without this diff, the classpath contains invalid entries: non relocated jgit output file. This diff relocates it to jgit cell.
[1] https://git.eclipse.org/r/61938 [2] https://gerrit-review.googlesource.com/73000