Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !569

Abstract AbstractJavacOptions away from building the command line

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/grumpyjames/feature/jvmlang-agnostic-14 into master Dec 10, 2015
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 6

Created by: grumpyjames

Summary:

Instead of getting it to build the list of command line strings, get JavacStep to visit AbstractJavacOptions with an OptionConsumer instead. This will allow other JavacOptions users to know about the command line flags without having to filter all the hyphens, for example when attempting to pass key value pairs to groovyc's -J flag.

Test Plan: CI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/grumpyjames/feature/jvmlang-agnostic-14