Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !575

Update okhttp and okio.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/LegNeato/update-okhttp into master Dec 12, 2015
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 8

Created by: LegNeato

okhttp-2.4.0 is required to get this change mentioned in https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-240-rc1 :

"Interceptors lists are now deep-copied by OkHttpClient.clone(). Previously clones shared interceptors, which made it difficult to customize the interceptors on a request-by-request basis."

Upgrading lets a future diff use different headers for read and write OkHttp clients.

I upgraded to the latest of both (okio is a dep) because why not.

Test Plan:

  • All tests passed.
  • Built with ant.
  • Built with buck.
  • Built with buck via in-repo python script.
  • Ran some builds with cache set to http and saw the requests worked
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/LegNeato/update-okhttp