Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !593

Use immutables to simplify some code in the query package.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mogers/immutables into master Jan 03, 2016
  • Overview 6
  • Commits 8
  • Pipelines 0
  • Changes 17

Created by: mogers

Summary: Unit tests for the QueryParser require the ability to compare QueryExpression's. Overriding equals() requires one to override hashCode() as well. This was done for FunctionExpression, SetExpression and Argument, but the code is a bit messy. This PR uses immutables to generate this code, making it less prone to errors.

Test plan: CI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mogers/immutables