Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !595

Cross-cell: Fix file system mismatch in classpath macro expansion

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/davido/fix_classpath_macro_resolution into master Jan 04, 2016
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: davido

Fixes: #594 (closed).

Summary: The absolutifier, used in macro owning rule may be from different cell.

That why it's always wrong to assume, that all classpath entries belong to the same file system. The rule own file system must be used to resolve every single classpath entry.

Test Plan:

Build Gerrit Code Review with this change applied: [1].

  • [1] https://gerrit-review.googlesource.com/73000
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davido/fix_classpath_macro_resolution