Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !615

Extract commonality from (Java|Groovy)LibraryDescription

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/grumpyjames/feature/jvmlang-agnostic-17 into master Jan 13, 2016
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 12

Created by: grumpyjames

Summary:

These two classes are in fact more similar than their implementations suggest. In this change we extract the common features to both Groovy and Java into JvmLibraryDescription, and reduce the previous classes to smaller configuration classes. This removes a lot of duplication while also adding flavours and maven support to groovy modules (documentation to follow).

Test-plan:

CI

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/grumpyjames/feature/jvmlang-agnostic-17