Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !652

Fix OnDiskMavenDownloader path not resolving properly on windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/janicduplessis/master into master Feb 12, 2016
  • Overview 16
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: janicduplessis

OnDiskMavenDownloader#fetch used root.resolve to convert the uri returned from the MavenUrlDecoder to a local file scheme. This did not work on Windows because of the drive letter.

file:///C:/com/android/support/support-v4/23.0.1/support-v4-23.0.1.aar

on windows vs

file:///com/android/support/support-v4/23.0.1/support-v4-23.0.1.aar

on mac/linux

This removes the extra uri conversion that was breaking the path because it is only used to log the DownloadEvent which can use the actual target path instead.

Tested by downloading support-v4 while building react-native on both mac and windows.

Fixes the 2nd issue in #649 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/janicduplessis/master