Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !695

Replace usages of static final fields on Guava's CharMatcher.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Dominator008/charmatcher into master Mar 09, 2016
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 8

Created by: Dominator008

This change replaces usages of static final fields on CharMatcher, eg. ChraMatcher.WHITESPAcE, with the equivalent static factory methods, eg. CharMatcher.whitespace().

Static final fields must be eagerly initialized, potentially causing many unnecessary implementation classes to be loaded. Using methods allow implementation classes to be loaded when actually needed.

These methods became available in Guava 19.0. Guava will eventually deprecate the static final fields.

See: https://github.com/google/guava/commit/d810fc4b42d80b64fd118c2cf1483fb7682d34a9.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Dominator008/charmatcher