Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !737

Remove dependencies tests when --without-dependencies-tests is used

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/nguyentruongtho/tho/fix_dependencies_tests into master May 06, 2016
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: nguyentruongtho

As @robbertvanginkel mentioned in https://github.com/facebook/buck/issues/710, this issue is pretty much a bug to be fixed.

This PR will fix that bug as following:

  1. When --without-dependencies-tests flag is used, test scheme for the specified target should be generated, but not for its dependencies.
  2. When --without-dependencies-tests flag is not used, test scheme for the specified target should contains all tests of its dependencies (old behavior).
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nguyentruongtho/tho/fix_dependencies_tests