Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !763

Fix the way environment is handled for worker_tool processes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mike Kaplinskiy requested to merge github/fork/mikekap/worker-tool-env into master May 25, 2016
  • Overview 7
  • Commits 2
  • Pipelines 0
  • Changes 13

Previously the worker process was started with environment variables from whatever first rule happened to start it.

This changes the behavior to:

  • allow specifying environment variables via env in worker_tool
  • remove step-specific environment variables from the worker launch environment.
  • moves $CWD to project root
  • moves $TMP to buck-out/bin/<worker_tool target>_worker

This way the worker is started the same way every time. It also avoids including the (potentially huge) environment from the genrule in an actual call to exec.

In terms of code organization, I followed the existing pattern, but I think perhaps it might make sense to move WorkerProcess startup into WorkerTool itself so we don't have to pass so many arguments around.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mikekap/worker-tool-env